libopenstorage / cloudops

Apache License 2.0
7 stars 13 forks source link

PWX-30093: OCP bring up issue with vSphere #141

Closed nrevanna closed 1 year ago

nrevanna commented 1 year ago
  vSphere client is being used in some paths which were being ignored
  thinking it's not needed. Reenabling them

What this PR does / why we need it:

Which issue(s) this PR fixes (optional) Closes #

Special notes for your reviewer: Testing: Ran the fix on the cluster provided by Santhosh and px came up.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (87b65c0) 8.07% compared to head (97732c0) 8.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #141 +/- ## ========================================= - Coverage 8.07% 8.06% -0.01% ========================================= Files 18 18 Lines 4681 4686 +5 ========================================= Hits 378 378 - Misses 4281 4286 +5 Partials 22 22 ``` | [Impacted Files](https://codecov.io/gh/libopenstorage/cloudops/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage) | Coverage Δ | | |---|---|---| | [vsphere/vsphere.go](https://codecov.io/gh/libopenstorage/cloudops/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage#diff-dnNwaGVyZS92c3BoZXJlLmdv) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.