Closed vinayakshnd closed 10 months ago
Attention: 24 lines
in your changes are missing coverage. Please review.
Comparison is base (
6dce65c
) 8.10% compared to head (c669efd
) 8.08%. Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
oracle/oracle.go | 0.00% | 24 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What this PR does / why we need it: Currently, cloudops only looks at the first volumeattachment from list of volumeattachements for a given volume in order to get its device path. But in case of failovers, (ie. existing storage node is deleted), same volume gets attached to new node creating a new volumeattachment which exists along with old volumeattachment for old node (in DETACHED state).
With this new PR, cloudops will go through list of all volumeattachements for a given volume and will use volumeattachement obj that is in ATTACHED state to find out device path.
Which issue(s) this PR fixes (optional) Closes # https://portworx.atlassian.net/browse/PWX-35366
Special notes for your reviewer:
Scenario 1: When device is detached.
Scenario 2: Device attached to an different instance (remote/ instance other than where code is running)
Scenario 3: Device attached on the same/local node where code is running.
Scenario 4: Device detached and re-attached with different path. Only the latest volumeattachment with updated devicepath reported.