search

libopenstorage / cloudops

Apache License 2.0
7 stars 13 forks source link

PWX-36933 - update decision matrix for new disk types #163

Closed dtalreja-px closed 6 months ago

dtalreja-px commented 6 months ago

What this PR does / why we need it: Update decision matrix for azure disks - premiumv2 and ultradisk

Which issue(s) this PR fixes (optional) PWX-36933

Special notes for your reviewer: Teted - PASS coverage: 90.9% of statements ok github.com/libopenstorage/cloudops/vsphere/storagemanager 0.010s coverage: 90.9% of statements

nrevanna commented 6 months ago

https://github.com/libopenstorage/cloudops/blob/PWX-36933/azure/storagemanager/testspecs/azure-storage-decision-matrix.yaml Needs an update too?

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 8.07%. Comparing base (86b2776) to head (5a6a6f1).

:exclamation: Current head 5a6a6f1 differs from pull request most recent head babf34f. Consider uploading reports for the commit babf34f to get more accurate results

Files Patch % Lines
azure/base_vmsclient.go 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #163 +/- ## ========================================= - Coverage 8.07% 8.07% -0.01% ========================================= Files 18 18 Lines 4729 4733 +4 ========================================= Hits 382 382 - Misses 4325 4329 +4 Partials 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.