search

libopenstorage / cloudops

Apache License 2.0
7 stars 13 forks source link

Adding support for GKE upgrade strategy #167

Closed nilanto07-px closed 4 months ago

nilanto07-px commented 5 months ago

What this PR does / why we need it: Adding support for maxSurge and maxUnavailable values for surge upgrade strategy in GKE

Reference: https://cloud.google.com/kubernetes-engine/docs/concepts/node-pool-upgrade-strategies#surge

Which issue(s) this PR fixes (optional) Closes # PTX-24373

Special notes for your reviewer: N/A

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 8.24%. Comparing base (64196e6) to head (6310e05).

Files Patch % Lines
gce/gce.go 0.00% 46 Missing :warning:
backoff/exponential.go 0.00% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #167 +/- ## ========================================= - Coverage 8.34% 8.24% -0.10% ========================================= Files 18 18 Lines 4793 4850 +57 ========================================= Hits 400 400 - Misses 4371 4428 +57 Partials 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nilanto07-px commented 4 months ago

LGTM as long as you tested that it works

https://github.com/portworx/torpedo/pull/2549 has the related tests covered.