search

libopenstorage / cloudops

Apache License 2.0
7 stars 13 forks source link

PWX-37576: API Usage: Pool expand - add-disk #174

Closed yjoshi-px closed 4 months ago

yjoshi-px commented 4 months ago

What this PR does / why we need it: Removed the QueryVirtualDiskUuid API call

Which issue(s) this PR fixes (optional) Closes # PWX-37576

Testing Notes Performed pool expansion from 60GB to 180GB using add-disk operation Before Fix Initial calls before pool expansion

Screenshot 2024-06-26 at 5 40 01 PM Screenshot 2024-06-26 at 5 41 33 PM

After Pool expansion

Screenshot 2024-06-26 at 5 42 20 PM Screenshot 2024-06-26 at 5 43 02 PM

After Fix Initial calls before pool expansion

Screenshot 2024-06-26 at 5 23 08 PM Screenshot 2024-06-26 at 5 23 59 PM

After pool expansion

Screenshot 2024-06-26 at 5 25 10 PM Screenshot 2024-06-26 at 5 25 34 PM

NOTE: The API calls for pool expansion before fix were 135 and after fix reduced to 10

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 8.22%. Comparing base (121ef09) to head (0d72e74).

Files Patch % Lines
vsphere/vsphere.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #174 +/- ## ========================================= + Coverage 8.21% 8.22% +0.01% ========================================= Files 18 18 Lines 4871 4865 -6 ========================================= Hits 400 400 + Misses 4449 4443 -6 Partials 22 22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.