libopenstorage / openstorage

A multi-host clustered implementation of the open storage specification
Apache License 2.0
524 stars 118 forks source link

Audit for foo, _ = someFnThatReturnsAnErrorAsSecondArgument() #106

Closed bufdev closed 6 years ago

bufdev commented 8 years ago
$ agg '_ ='
cli/volumes.go:18:  _ = iota
cluster/manager.go:109: c.selfNode.Cpu, _, _ = s.CpuUsage()
cluster/manager.go:116: c.selfNode.Containers, _ = c.docker.ListContainers(docker.ListContainersOptions{All: true})
cluster/manager.go:350: c.selfNode.Ip, _ = externalIp()
graph/drivers/layer0/layer0.go:247:             _ = l.volDriver.Detach(v.volumeID)
api/server/volume.go:242:       vols, _ = d.Enumerate(locator, configLabels)
volume/drivers/fuse/volume_driver.go:115:       _ = fs.Serve(conn, filesystem)
volume/drivers/fuse/volume_driver.go:116:       _ = conn.Close()
api/server/docker.go:136:           spec.Ephemeral, _ = strconv.ParseBool(v)
api/server/docker.go:138:           spec.Size, _ = strconv.ParseUint(v, 10, 64)
api/server/docker.go:151:           spec.Dedupe, _ = strconv.ParseBool(v)
api/server/docker.go:325:       _ = v.Detach(volInfo.vol.ID)
pkg/mount/mount_test.go:59: exists, _ = m.Exists(source, dest)
$ agg '_ :='
cli/messages.go:81: b, _ := json.MarshalIndent(body, "", " ")
cli/messages.go:94:     b, _ := json.MarshalIndent(format, "", " ")
cli/messages.go:106:        b, _ := json.MarshalIndent(format.Result, "", " ")
api/client/request_test.go:11:  u, _ := url.Parse("http://localhost:8000")
api/client/request_test.go:14:  b, _ := json.Marshal(l)
api/client/request_test.go:26:  url, _ := url.Parse("http://localhost:8000")
api/client/request_test.go:36:  url, _ := url.Parse("http://localhost:8000")
cluster/manager.go:375:     self, _ := c.initNode(&db)
api/server/docker.go:142:           blockSize, _ := strconv.ParseInt(v, 10, 64)
api/server/docker.go:145:           haLevel, _ := strconv.ParseInt(v, 10, 64)
api/server/docker.go:148:           cos, _ := strconv.ParseInt(v, 10, 64)
api/server/docker.go:153:           snapshotInterval, _ := strconv.ParseInt(v, 10, 64)
cmd/osd/main.go:103:    for d, _ := range cfg.Osd.GraphDrivers {
volume/drivers/nfs/nfs.go:81:   directory, _ := os.Open(source)
volume/drivers/buse/nbd.go:231:             n, _ := syscall.Read(nbd.socket, buf[28:28+x.len])
volume/drivers/buse/nbd.go:233:                 m, _ := syscall.Read(nbd.socket, buf[28+n:28+x.len])
pkg/mount/mount_test.go:57: exists, _ := m.Exists(source, "foo")
lpabon commented 6 years ago

Closing since it has had no update for more than 6 months. Please reopen if needed.