search

libopenstorage / secrets

Openstorage support for Key Management Systems
Apache License 2.0
16 stars 16 forks source link

update key protect go client and also adjust the mock test #58

Open humblec opened 2 years ago

humblec commented 2 years ago

lift key protect client to latest version

This commit lift the key protect client version from

 github.com/IBM/keyprotect-go-client v0.5.1
  to
 github.com/IBM/keyprotect-go-client v0.7.0

which is the latest release available now. This PR also adjust mock tests for key protect secret test

humblec commented 2 years ago

Cc @leseb

humblec commented 2 years ago

Cc @adityadani

humblec commented 2 years ago

nit: The comment in the 2nd commit does not seem really correct. I guess the secrets.mock.go was re-generated with new testify, or something. It is not only for IBM KeyProtect.

Thats correct, its a general update as you mentioned @nixpanic , adjusting the commit message.

humblec commented 2 years ago

nit: The comment in the 2nd commit does not seem really correct. I guess the secrets.mock.go was re-generated with new testify, or something. It is not only for IBM KeyProtect.

Thats correct, its a general update as you mentioned @nixpanic , adjusting the commit message.

Done..

humblec commented 2 years ago

@adityadani can you please take a look at this PR ? or assign this PR to the correct github id?