search

libopenstorage / secrets

Openstorage support for Key Management Systems
Apache License 2.0
16 stars 16 forks source link

convert vault auth code from busl to mpl libraries #80

Closed BlaineEXE closed 1 year ago

BlaineEXE commented 1 year ago

What this PR does / why we need it:

Switch usage of Vault libraries that are licensed under Business Source License (BUSL-1.1) in favor of Vault libraries licensed under the the open source Mozilla Public License (MPL-2.0).

In practice, this means avoiding code imported by github.com/hashicorp/vault/command which is part of the top-level Vault application licensed under BUSL-1.1 and instead using code imported by github.com/hashicorp/vault/api which is not part of the top-level Vault application and which is licensed under the open source MPL-2.0 license.

Which issue(s) this PR fixes (optional) Resolves #79

Special notes for your reviewer:

BlaineEXE commented 1 year ago

Requesting review from @ggriffiths @dahuang-purestorage, and @adityadani, please and thank you.

Currently this is a draft PR while I am also letting Rook's CI test Rook's Vault integration with changes proposed here.

Rook PR updated to use WIP of this branch here: https://github.com/rook/rook/pull/13032

BlaineEXE commented 1 year ago

K8s auth integration passes in Rook's CI here: https://github.com/rook/rook/actions/runs/6474391180/job/17579208709?pr=13032

We've at least been able to vet that these changes don't cause any issues for Rook's usage of Vault secrets integration with K8s. Based on that, I don't think breakage of other consumers is a risk.

BlaineEXE commented 1 year ago

Is it normal that the AWS and Google secrets tests fail? They look like issues with setting up the tests rather than failures in the secret library.

BlaineEXE commented 1 year ago

Likewise, thank you!