libopenstorage / secrets

Openstorage support for Key Management Systems
Apache License 2.0
16 stars 16 forks source link

migrate from adal to azidentity #83

Open sp98 opened 7 months ago

sp98 commented 7 months ago

adal is out of support since March 31, 2023. This PR migrates from adal to azidentity for azure key vault. Migration guide was used as a reference.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional) Closes #84

Special notes for your reviewer:

sp98 commented 6 months ago

@dahuang-purestorage Hi, can you please take a look at this PR. The change to support certificates based auth was very small to included in the same PR. If you want, I can open a different PR for that as well. Thanks.

cc @adityadani

sp98 commented 1 week ago

@adityadani Hi. This got delayed a bit due to other commitments. I plan to address your review comments this week. Hope we can get this merged soon. Thanks.