libopenstorage / stork

Stork - Storage Orchestration Runtime for Kubernetes
Apache License 2.0
392 stars 89 forks source link

pwx-22735: add auth annotations in volumesnapshot #1854

Closed strivedi-px closed 1 month ago

strivedi-px commented 1 month ago

What type of PR is this? bug

What this PR does / why we need it: Adds the authentication related annotations in stork volumesnapshots in order to fix volume snapshotting in auth clusters.

Does this PR change a user-facing CRD or CLI?: No

Is a release note needed?: No

Does this change need to be cherry-picked to a release branch?: Yes, 24.4.0 branch.

Test run https://jenkins.pwx.dev.purestorage.com/job/Users/job/strivedi/job/snapshot-auth-cluster/22/ https://jenkins.pwx.dev.purestorage.com/job/Users/job/strivedi/job/snapshot-auth-cluster/17/

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 32.77%. Comparing base (4580c07) to head (76e865b). Report is 6 commits behind head on stork-dr-next.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## stork-dr-next #1854 +/- ## ============================================== Coverage 32.77% 32.77% ============================================== Files 60 60 Lines 13665 13665 ============================================== Hits 4479 4479 Misses 8784 8784 Partials 402 402 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.