libopenstorage / stork

Stork - Storage Orchestration Runtime for Kubernetes
Apache License 2.0
392 stars 89 forks source link

fix: keep the default value of kubevirt-skip-preload-statfs flag as false #1875

Closed strivedi-px closed 1 day ago

strivedi-px commented 2 days ago

What type of PR is this? failing-test

What this PR does / why we need it: The TestExtenderWebhookStatFS test was failing on 24.3.3-dev and 24.4.0-dev image since the value of the kubevirt-skip-preload-statfs flag was set to True by default. This was because we used the BoolTFlag to define the flag which keeps the default value of the flag as True. Due to this, the statfs binary preload workflow was deactivated by default. Making it false by default.

In order to deactivate the statfs preload hack, the kubevirt-skip-preload-statfs=true stork arg would need to be set.

Does this PR change a user-facing CRD or CLI?: No

Is a release note needed?: No

Does this change need to be cherry-picked to a release branch?: No, directly made the PR to 24.3.3 branch since had cherry-picked the code change commit to the release-24.3.3 branch only from pure-px/stork.

Test run https://jenkins.pwx.dev.purestorage.com/job/Stork/view/Stork%2024.3.3-dev/job/extender-op-k8s-1-30-0/612/