use_page_alloc - Githubissues

jyizheng commented 9 years ago

Make page_alloc.c and etc. compiled in the linux.so

landscape-bot commented 9 years ago

Code quality remained the same when pulling 13c94a1 on jyizheng:nuse into 14929c5 on libos-nuse:nuse.

landscape-bot commented 9 years ago

Code quality remained the same when pulling abebc87 on jyizheng:nuse into 14929c5 on libos-nuse:nuse.

landscape-bot commented 9 years ago

Code quality remained the same when pulling 05cd7d3 on jyizheng:nuse into 14929c5 on libos-nuse:nuse.

thehajime commented 9 years ago

Yizheng,

I put comments for a couple of files and found your patches is not for the latest master.

now nuse branch is no longer the default and latest branch: please merge the latest master branch into your private branch, rebase it, and submit PR again.

thanks.

jyizheng commented 9 years ago

Sure. I will try to sync with the latest code. Thanks for all you comments.

Yizheng

On Sun, Jun 21, 2015 at 10:59 PM, Hajime Tazaki notifications@github.com wrote:

Yizheng,

I put comments for a couple of files and found your patches is not for the latest master.

now nuse branch is no longer the default and latest branch: please merge the latest master branch into your private branch, rebase it, and submit PR again.

thanks.

— Reply to this email directly or view it on GitHub https://github.com/libos-nuse/net-next-nuse/pull/44#issuecomment-113988150 .

jyizheng commented 9 years ago

I really don't know how to make my repository synchronized with the lastes code. Is it possible to help me out?

On Tue, Jun 23, 2015 at 1:03 PM, Andy Joe jyizheng@gmail.com wrote:

Sure. I will try to sync with the latest code. Thanks for all you comments.

Yizheng

On Sun, Jun 21, 2015 at 10:59 PM, Hajime Tazaki notifications@github.com wrote:

Yizheng,

I put comments for a couple of files and found your patches is not for the latest master.

now nuse branch is no longer the default and latest branch: please merge the latest master branch into your private branch, rebase it, and submit PR again.

thanks.

— Reply to this email directly or view it on GitHub https://github.com/libos-nuse/net-next-nuse/pull/44#issuecomment-113988150 .

thehajime commented 9 years ago

@jyizheng to synchronize your code to the master, 'git rebase' is the way for your pull request so that I can merge your patches on top of net-next-nuse tree (i.e., fast-forward merge).

for instance,

git checkout (your branch)
git rebase origin/master

thehajime commented 9 years ago

@jyizheng I expect you cloud clean up PR #47 by git-rebase.

jyizheng commented 9 years ago

OK. Let me try it.

On Wed, Aug 26, 2015 at 2:56 AM, Hajime Tazaki notifications@github.com wrote:

@jyizheng https://github.com/jyizheng I expect you cloud clean up PR #47 https://github.com/libos-nuse/net-next-nuse/pull/47 by git-rebase.

— Reply to this email directly or view it on GitHub https://github.com/libos-nuse/net-next-nuse/pull/44#issuecomment-134867547 .

jyizheng commented 9 years ago

I don't know whether I have successfully merged my patches. Please check. If it not, can we set up an online meeting some time to fix the problem?

thehajime commented 9 years ago

@jyizheng hmm, I couldn't find your merged patches. I will contact you privately for an online meeting.

libos-nuse / net-next-nuse

use_page_alloc #44