search

libos-nuse / net-next-nuse

Network Stack in Userspace
Other
287 stars 67 forks source link

Fix arch/lib/Makefile: from git:// to https:// #57

Closed nrybowski closed 2 years ago

nrybowski commented 2 years ago

GitHub dropped today its support of the git:// protocol. See https://github.blog/2021-09-01-improving-git-protocol-security-github/.

This change is Reviewable

thehajime commented 2 years ago

Thanks too ! Just out of curiosity; are you using this now? I thought there are not so many.

nrybowski commented 2 years ago

Hello @thehajime, I'm indeed using libos currently to have a linux kernel within DCE and play with IGP implementations in ns-3.

I forgot to say that the tag libos-v4.4 should also be modified in order to take into account this commit. The dce-linux-dev build is currenlty broken because of that (https://gitlab.com/nsnam/bake/-/blob/master/bakeconf.xml#L355).

thehajime commented 2 years ago

I forgot to say that the tag libos-v4.4 should also be modified in order to take into account this commit. The dce-linux-dev build is currenlty broken because of that (https://gitlab.com/nsnam/bake/-/blob/master/bakeconf.xml#L355).

I see. We need to have a specific branch with this fix for the tag (v4.4) as the current master is 4.7-base while bake still points to the specific tag (4.4). I'm not sure how the current master needs more tests with bake. Will investigate this later.

thehajime commented 1 year ago

now this patch is applied to the new (history-rewritten) master: 353b020d793cf405cc68188c298520c619028f04.

We plan to update bakeconf with new tag including this fix so that there would be no further issue in coming releases. Thanks for the patch !