Refactor read write some

libp2p / cpp-libp2p

C++17 implementation of libp2p

Apache License 2.0

346 stars 97 forks source link

Closed turuslan closed 7 months ago

turuslan commented 1 year ago

Deduplicate Reader::read/Writer::write implementations with free read/write which use Reader::readSome/Writer::writeSome
read/write success means exactly size bytes were read/write. So callbacks don't need outcome<size>. This prevents redundant size checks in callbacks. Callbacks will capture buffer size if they need it.
Fix yamux writeSome (can't writeSome/split already encoded frame with length in header)

igor-egorov commented 7 months ago

Probably, we have to raise clang version for Ubuntu CI host. (Not mandatory for this PR)