search

libp2p / devgrants

want to hack on libp2p? this repo tracks libp2p endeavors eligible for incentivization.
https://libp2p.io
Other
40 stars 3 forks source link

Implement MDNS discovery in go per the new spec #11

Open Stebalien opened 5 years ago

Stebalien commented 5 years ago

This project is specified here: 011-mdns-go-js.md.

vasco-santos commented 5 years ago

I agree with implementing MDNS discovery according to the new spec should be a priority.

Other than go, the same should happen for JS, also aiming to get the interoperable side of things.

@Stebalien @raulk I think we could include JS in this issue, what do you think? Otherwise, I can create a new issue to track JS.

raulk commented 5 years ago

@vasco-santos - I've added the JS label to this issue now.

Stebalien commented 5 years ago

Other than go, the same should happen for JS, also aiming to get the interoperable side of things.

I thought js already implemented the new spec. Is that not the case?

jacobheun commented 5 years ago

No, a compatibility layer was added a few months ago to get interop functioning with go. Ideally we'd get both implemented together and scrap all of that shenanigans.

Stebalien commented 5 years ago

Ah, so JS implements one thing, Go implements another, and the spec specifies a third? I guess we finally have a real spec.

vasco-santos commented 5 years ago

Ah, so JS implements one thing, Go implements another, and the spec specifies a third? I guess we finally have a real spec.

Yeah, that's the current state of things

semtexzv commented 4 years ago

Rust implementation implements the spec. Go & JS implementations do not. https://github.com/libp2p/rust-libp2p/issues/1678