search

libp2p / docs

Documentation site for the libp2p project.
https://docs.libp2p.io/
Other
60 stars 89 forks source link

Repair dead links #338

Closed dchiquito closed 1 year ago

dchiquito commented 1 year ago

Fixes #309

I used lychee --verbose --exclude twitter.com ./public/ to check for dead links to fix. twitter.com is excluded because @libp2p is not accessible without logging in.

This expands on #337 , which fixed the dead links in the introduction.

p-shahi commented 1 year ago

@dchiquito Thanks for this change, I believe another PR recently merged introduced a conflict. Can you resolve it?

p-shahi commented 1 year ago

@dchiquito Are you interested in adding this check to CI?

dchiquito commented 1 year ago

@p-shahi It's already there, actually! It's set to only run on demand, nothing but a manual intervention triggers it at the moment.

I can put in a PR to disable twitter.com checks and run it on any pushes, since it doesn't seem to have much visibility at the moment.

dchiquito commented 1 year ago

It turns out I was not using lychee correctly and it was allowing a bunch of false negatives. I filed #342 to continue working on it.