Open Stebalien opened 6 years ago
Example for point 4:
Listen("/p2p-circuit")
returns a listener that listens for all inbound circuit relay connections.Listen("/ipfs/QmRelay/p2p-circuit")
returns a listener that only accepts relayed connections from QmRelay
.This is kind of pedantic but it allows users select which peers they want to use as relays (may be useful in cases where some links are cheaper than others).
I think point (2) is the really important one, as it ensures we have a connection open to the relay.
@vyzo given that we've now enabled relay by default in go-libp2p, I'd like to fix this (at least point 3) ASAP so we can remove this dance.
That is, we should:
/p2p-circuit
.NoListenAddrs
.That's fine by me.
@vyzo wondering if we made progress with this? I recall seeing related changes come through.
no progress to be reported.
Listen("/p2p-circuit")
should behave as it does today.Listen("/ipfs/QmOther/p2p-circuit")
should dialQmOther
, keep the connection open (and fail to listen if we can't dial them), and check if they support relaying./p2p-circuit
. Currently, we just check if it contains/p2p-circuit
and accept it.Listen
to signal that we accept relayed connections (and from where).