Use NoDial option when opening hop streams for non-active relays

libp2p / go-libp2p-circuit

Circuit Switching for libp2p

MIT License

48 stars 16 forks source link

Use NoDial option when opening hop streams for non-active relays #70

Closed vyzo closed 5 years ago

vyzo commented 5 years ago

It turns out that the relays are doing dialing on NewStream in the wild, presumably because they still have dead connections. This uses the new NoDial option to instruct the swarm to not dial the hop target instead of explicitly checking for open connections and is robust to failed connections.

vyzo commented 5 years ago

gx build failures are to be expected...

vyzo commented 5 years ago

@Stebalien LGTM'ed over slack, as he is on mobile, so merging.