search

libp2p / go-libp2p-examples

Example libp2p applications
MIT License
338 stars 145 forks source link

Use full DHT bootstrap list and update deps #45

Closed anacrolix closed 5 years ago

anacrolix commented 5 years ago

Uses the full DHT bootstrap list. Builds on https://github.com/libp2p/go-libp2p-examples/pull/40.

anacrolix commented 5 years ago

The CircleCI should pass when #46 is merged.

anacrolix commented 5 years ago

Actually it's exactly this situation that go mod solves most elegantly. There is no tagged version of the dht that provides the desired features at present, nor does there need to be. The specified revision is the minimum that this package revision, and all downstream packages (of which there are none in this case), depending on it can use. It might look strange in this case, but it is correct. An occasional "update" pass on the go.mod file would normally smooth this over when the DHT does get tagged.

anacrolix commented 5 years ago

It's also worth pointing out that it won't fall out of sync. Downstreams or upstreams (visibly) will raise the minimum version. There's no lockstep nonsense.

anacrolix commented 5 years ago

I've bumped the deps after observing https://github.com/libp2p/go-libp2p/issues/529#issuecomment-461175029.

anacrolix commented 5 years ago

@raulk let's get this merged.