search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
525 stars 226 forks source link

flaky TestSkipRefreshOnGapCpls test #722

Open marten-seemann opened 3 years ago

marten-seemann commented 3 years ago

When running with race detector. Timing issue?


 === RUN   TestSkipRefreshOnGapCpls
      rt_refresh_manager_test.go:42: 
            Error Trace:    rt_refresh_manager_test.go:42
                                        rt_refresh_manager.go:298
                                        rt_refresh_manager.go:279
                                        rt_refresh_manager.go:212
                                        rt_refresh_manager.go:234
                                        rt_refresh_manager_test.go:89
            Error:          Should be true
            Test:           TestSkipRefreshOnGapCpls
  --- FAIL: TestSkipRefreshOnGapCpls (0.00s)
  FAIL
  FAIL  github.com/libp2p/go-libp2p-kad-dht/rtrefresh   0.056s
marten-seemann commented 3 years ago

Probably not a timing issue. I can reliably reproduce this locally by running the tests with -count=100.