search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
517 stars 221 forks source link

Specify CODEOWNERS #825

Closed BigLep closed 1 year ago

BigLep commented 1 year ago

Done Criteria

It is clear who are the owners of this repo, and that one of them is required to merge PRs

Why Important

This repo has shared ownership across a few different PL EngRes teams. A problem with shared ownership is that then no one feels directly responsible or contributors don't know who to reach out to. This repo has had 70+ contributors over the years and assuming others outside PL EngRes contribute in the future, we'll give them clarity on the shared ownership state.

Notes

Owners should be:

BigLep commented 1 year ago

@guillaumemichel : I'm hoping this is something you can take as part of giving some attention to this repo.

guillaumemichel commented 1 year ago

Yes definitely! And I'll make sure to ping the right people to review my own PRs

guillaumemichel commented 1 year ago

Added a maintainers section in the readme, for both go-libp2p-kad-dht and go-lib2p-kbucket.

Feel free to reopen if something isn't clear.

See:

BigLep commented 1 year ago

Question @guillaumemichel : any reason not to put that in CODEOWNERS rather than a README which is the cananoical place for that information (and enables ensuring each PR gets a review from one of the CODEOWNERS).

guillaumemichel commented 1 year ago

@BigLep updated in https://github.com/libp2p/go-libp2p-kad-dht/pull/828

guillaumemichel commented 1 year ago

https://github.com/libp2p/go-libp2p-kad-dht/pull/828 merged. Closing the issue