search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
517 stars 221 forks source link

Specified CODEOWNERS #828

Closed guillaumemichel closed 1 year ago

guillaumemichel commented 1 year ago

I tried to split code ownership between go-libp2p and kubo maintainers. Please let me know your thoughts

https://github.com/libp2p/go-libp2p-kad-dht/issues/825

guillaumemichel commented 1 year ago

The CODEOWNER file seems not to accept @ipfs/kubo-maintainers.

kubo-maintainers

I wasn't able to give write permissions to @ipfs/kubo-maintainers.

kubo-maintainers2

Is it possible to give write permissions to a team from a different org?

cc: @BigLep @galargh

guseggert commented 1 year ago

LGTM just need to fix the team somehow, after that I'll approve

galargh commented 1 year ago

Is it possible to give write permissions to a team from a different org?

Nope, but we can create kubo-maintainers team in this org too. You can copy https://github.com/ipfs/github-mgmt/blob/d8bfce1a65dfcc34ba5f780b9aaaf5c68916d2cc/github/ipfs.yml#L6020 to https://github.com/libp2p/github-mgmt/blob/27021f542d76f1493c5ae1102a80844e153113fc/github/libp2p.yml#L4798

guillaumemichel commented 1 year ago

It would be great to have the approval of @MarcoPolo or @marten-seemann before we merge