search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
517 stars 221 forks source link

ignoring incoming dht message while not in server mode #838

Closed thewaytoai closed 10 months ago

thewaytoai commented 1 year ago
github.com/libp2p/go-libp2p v0.24.2

I have no idea why my node shows this error. Is it normal or anything wrong in my network?

Shawn-Huang-Tron commented 1 year ago

Me too. It's appeared frequently and I can't ignore because the log level don't work.

MarcoPolo commented 1 year ago

log line: https://github.com/libp2p/go-libp2p-kad-dht/blob/f4e8e869905f4a6854999d2cbd0f0ce107e456ef/dht_net.go#L47

MarcoPolo commented 1 year ago

Should be an easy fix, @Shawn-Huang-Tron or @theWayToAI, want to take a stab at fixing this? We could probably just make it a debug log.

Shawn-Huang-Tron commented 1 year ago

I think that change it to a debug log is enough. Thanks.

lidel commented 1 year ago

triage note: @Jorropo said he is working on a patch :^)

Jorropo commented 1 year ago

I thought I could fix it, I was wrong, changing it to debug looks fine.

GheisMohammadi commented 11 months ago

hey team, any update on this issue?

MarcoPolo commented 11 months ago

@GheisMohammadi want to volunteer a fix?

GheisMohammadi commented 11 months ago

Certainly! I've already submitted the necessary changes (#860)

Jorropo commented 11 months ago

860 looks good but we should investigate how we are receiving message, the stream handler shouldn't be visible if you are a dht client.