search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
524 stars 224 forks source link

NuNet sees "Persistent error message related to grpc" #848

Closed dennis-tra closed 1 year ago

dennis-tra commented 1 year ago

The NuNet folks encountered errors related to tracing it seems. Their relevant GitLab issue is here:

https://gitlab.com/nunet/device-management-service/-/issues/163#note_1385291027

Opening a tracking issue here to draw attention to it.

Their log excerpt:

2023/05/10 15:24:15 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:24:20 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:24:25 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:24:30 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:24:35 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:24:40 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:24:45 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:24:50 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:24:55 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:00 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
[GIN] 2023/05/10 - 15:25:01 | 200 |      362.81µs |       127.0.0.1 | GET      "/api/v1/peers"
[GIN] 2023/05/10 - 15:25:01 | 200 |     286.186µs |       127.0.0.1 | GET      "/api/v1/peers/dht"
2023/05/10 15:25:05 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:10 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:15 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:20 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:25 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:30 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:35 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:40 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:45 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:50 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:25:55 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:26:00 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:26:05 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:26:10 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:26:15 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
2023/05/10 15:26:20 traces export: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8
smigad commented 1 year ago

Hi Dennis, Thank you very much for following up on this. I'd just like to recommend you change the title to either "opentelemetry - protobuf invalid utf-8 error" or something to that effect because I created the first issue as "persistent error message related to grpc" as soon as I run into the issue without looking into what it was causing it. The actual problem is that protobuf expects actual utf-8 when serializing. This issue might be of help: https://github.com/golang/protobuf/issues/1228

dennis-tra commented 1 year ago

@dagiopia could this be fixed with: https://github.com/libp2p/go-libp2p-kad-dht/pull/859 ?

guillaumemichel commented 1 year ago

Closing as it should have been fixed by https://github.com/libp2p/go-libp2p-kad-dht/pull/859. Feel free to reopen if the issue persists