search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
517 stars 221 forks source link

manual release created (v0.24.1) #852

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

@Jorropo just pushed a release tag: v0.24.1. Please manually verify validity (using `gorelease`), and update `version.json` to reflect the manually released version, if necessary. In the future, please use the automated process.

Jorropo commented 1 year ago

I know couldn't get version.json to work on a non master branch on this repo for some reason.

marten-seemann commented 1 year ago

@galargh Theres repeatedly problems reported with the uCI release workflow, as reported by @Jorropo. Could you take a look please?

Jorropo commented 1 year ago

It's likely I don't know how to do it. Basically from what I recall you make a branch named release-vX.Y.Z and merge a version.json update on it as usual. Somehow it didn't made the tag so I just made it myself. (this failed for v0.24.0, I didn't tried for v0.24.1 and just did the tag too).

galargh commented 1 year ago

If I understand correctly, you were trying to make a release on a release branch rather than the default one. In that case, you need to add release label to the PR that modifies version.json (as per https://github.com/protocol/.github/blob/master/VERSIONING.md#using-a-release-branch). Could you let me know if that works the next time you need to release?