search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
517 stars 221 forks source link

manual release created (v0.24.2) #854

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

@Jorropo just pushed a release tag: v0.24.2. Please manually verify validity (using `gorelease`), and update `version.json` to reflect the manually released version, if necessary. In the future, please use the automated process.

Jorropo commented 1 year ago

cc @galargh I tried the instruction but:

  1. no release label were existing, so I made a new one idk if it's correct.
  2. it didn't do the release

https://github.com/libp2p/go-libp2p-kad-dht/pull/853

galargh commented 1 year ago

The tag gets created after the merge. I can see that the release check created the draft release (https://github.com/libp2p/go-libp2p-kad-dht/actions/runs/5317866054/jobs/9628796756) and that the releaser workflow run after the merge but the tag already existed - https://github.com/libp2p/go-libp2p-kad-dht/actions/runs/5317898171/jobs/9628857314. Did you create the tag before merge?

Also, when you're merging to the default branch, you don't need the label.