search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
517 stars 221 forks source link

tracing: fix DHT keys as string attribute not being valid utf-8 #859

Closed MichaelMure closed 1 year ago

MichaelMure commented 1 year ago

Fix https://github.com/libp2p/go-libp2p-kad-dht/issues/858

Jorropo commented 1 year ago

Ok nvm, having the conditional is fine, let's still use a multibase to encode it.

github-actions[bot] commented 1 year ago

Suggested version: v0.24.3

Comparing to: v0.24.2 (diff)

Changes in go.mod file(s):

(empty)

gorelease says:

# diagnostics
go.mod: the following requirements are needed
    github.com/ipfs/go-ipfs-util@v0.0.2
    github.com/ipfs/go-ipns@v0.3.0
Run 'go mod tidy' to add missing requirements.
required module github.com/microcosm-cc/bluemonday@v1.0.1 retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.24.3

gocompat says:

Your branch is up to date with 'origin/master'.

Automatically created GitHub Release

Pre-creating GitHub Releases on release PRs initiated from forks is not supported. If you wish to prepare release notes yourself, you should create a draft GitHub Release for tag v0.24.3 manually. The draft GitHub Release is going to be published when this PR is merged. If you choose not to create a draft GitHub Release, a published GitHub Released is going to be created when this PR is merged.