search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
517 stars 221 forks source link

go-libp2p-kad-dht version 2 #864

Closed dennis-tra closed 6 months ago

dennis-tra commented 11 months ago

This is a draft pull request that shows the changes of version 2 to the go-libp2p-kad-dht repository.

iand commented 11 months ago

This looks pretty clean. Does it build after go mod tidy?

dennis-tra commented 11 months ago

Also enables https://github.com/libp2p/go-libp2p-kad-dht/issues/331 and addresses https://github.com/libp2p/go-libp2p-kad-dht/issues/337

guillaumemichel commented 10 months ago

Test in coord failing (see job)

  === RUN   TestBootstrap
      coordinator_test.go:251: saw event: *coord.EventRoutingUpdated
      coordinator_test.go:251: saw event: *coord.EventBootstrapFinished
      coordinator_test.go:270: 
            Error Trace:    /home/runner/work/go-libp2p-kad-dht/go-libp2p-kad-dht/v2/coord/coordinator_test.go:270
            Error:          Received unexpected error:
                            node not found
            Test:           TestBootstrap
  --- FAIL: TestBootstrap (0.00s)
iand commented 10 months ago

Test in coord failing (see job)

  === RUN   TestBootstrap
      coordinator_test.go:251: saw event: *coord.EventRoutingUpdated
      coordinator_test.go:251: saw event: *coord.EventBootstrapFinished
      coordinator_test.go:270: 
              Error Trace:    /home/runner/work/go-libp2p-kad-dht/go-libp2p-kad-dht/v2/coord/coordinator_test.go:270
              Error:          Received unexpected error:
                              node not found
              Test:           TestBootstrap
  --- FAIL: TestBootstrap (0.00s)

This run is from the Musa Bootstrapper branch. That test failure was fixed in #880

iand commented 10 months ago

Once https://github.com/libp2p/go-libp2p-kad-dht/issues/954 is complete this PR will be closed and the v2-develop branch deleted.

guillaumemichel commented 6 months ago

Closing as v2 has moved to Zikade