search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
516 stars 221 forks source link

Test query interactions with routing table #887

Closed iand closed 9 months ago

iand commented 10 months ago

This change ports two tests from v1: TestRTAdditionOnSuccessfulQuery and TestRTEvictionOnFailedQuery

Part of #888

iand commented 10 months ago

There is an occasional test failure which is caused by a race in the routing table. This needs https://github.com/plprobelab/go-kademlia/issues/115 to be completed (see https://github.com/plprobelab/go-kademlia/pull/121)

iand commented 10 months ago

Test failure is a test from this PR. I will investigate.

iand commented 10 months ago

I've merged a version of https://github.com/libp2p/go-libp2p-kad-dht/pull/890 into this to get access to working builds. There should not be any conflicts but it would probably be better to merge this after #820 since that has had a couple of recent small changes plus https://github.com/libp2p/go-libp2p-kad-dht/pull/896 is about to be merged into it

Requires https://github.com/plprobelab/go-kademlia/pull/122

iand commented 9 months ago

@dennis-tra should be ready for another look