libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
524 stars 224 forks source link

Give dht and coordinator their own telemetry instances #891

Closed iand closed 1 year ago

iand commented 1 year ago

Decouple dht and coordinator metrics so we separate responsibilities cleanly. Both components will use the same meter and tracer providers by default.

This also removes the error return from DefaultCoordinatorConfig() which was only needed because it was initializing a Telemetry struct with metrics that it does not touch.

dennis-tra commented 1 year ago

That error return value bugged me as well! Thanks for removing it!

iand commented 1 year ago

@dennis-tra happy for me to merge this?