search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
521 stars 223 forks source link

Add RoutingDHT that implements the routing.Routing interface #947

Closed dennis-tra closed 8 months ago

dennis-tra commented 1 year ago

Not sure I like that. It would also be good to point to the concerns that people have with the routing.Routing interface. This makes the tests look a little less nice unless we let the topology solely operate on RoutingDHT's.

fixes #929

iand commented 1 year ago

We should debate whether this actually belongs in Boxo, for example here

iand commented 1 year ago

Just thinking about how best to decouple the Routing adapter

Can we avoid accessing the host field on the DHT (and the Peerstore method)? Places where we do that are candidates for useful methods to expose on the DHT type, for example: Connectedness(), PeerInfo(), ID(), Addrs(), AddAddrs()

Same for accessing .kad - these could be methods on the DHT type that delegate to kad.

These aren't essential for this PR but something to think about as we evolve the usability of this implementation.

iand commented 1 year ago

As per https://github.com/libp2p/go-libp2p-kad-dht/issues/954 this needs to be applied to zikade

guillaumemichel commented 8 months ago

Closing as v2 has moved to Zikade

Reference: https://github.com/probe-lab/zikade/issues/78