search

libp2p / go-libp2p-kad-dht

A Kademlia DHT implementation on go-libp2p
https://github.com/libp2p/specs/tree/master/kad-dht
MIT License
521 stars 223 forks source link

fix: flaky test by skipping connectivity checks #955

Closed dennis-tra closed 8 months ago

dennis-tra commented 1 year ago

By skipping connectivity checks we reduce the chances of simultaneously opening a stream that will block connection establishment.

Context: https://github.com/libp2p/go-libp2p/issues/2589

iand commented 1 year ago

Maybe a better solution for your test is to allow a Coordinator to be created with a NoopRoutingBehaviour. The behaviours are intended to be modular and replaceable but we haven't exposed a convenient way of doing that.

iand commented 1 year ago

As per https://github.com/libp2p/go-libp2p-kad-dht/issues/954 this needs to be applied to zikade

guillaumemichel commented 8 months ago

Closing as v2 has moved to Zikade

See https://github.com/probe-lab/zikade/issues/77