Fixes #89 - Use functional opts to create Routing Table

libp2p / go-libp2p-kbucket

A kbucket implementation for use as a routing table

MIT License

48 stars 35 forks source link

Fixes #89 - Use functional opts to create Routing Table #102

Closed xprazak2 closed 3 years ago

xprazak2 commented 3 years ago

@aarshkshah1992 was this what you had in mind?

Any thoughts on backwards compatibility? Otherwise changes will be needed in go-libp2p-kad-dht and maybe other places.

aschmahmann commented 3 years ago

Thanks for the PR. This will break some upstream users at the moment and it's not a very high priority item for the folks who could review and navigate the associated changes.

To avoid accidentally wasting effort in the future it'd be useful to discuss on the issue that you're going to start work as described in our policy https://github.com/ipfs/community/blob/master/CONTRIBUTING_GO.md#code-change-policy