libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
321 stars 185 forks source link

Fragmentation for the hello packet #354

Closed requilence closed 3 years ago

requilence commented 4 years ago

We have the node with a lot of pubsub subscriptions and observing this problem:

As a result, pubsub generates 20Mbit outbound 😬

This PR uses fragmentRPC introduced in #320 to split the helloPacket payload

jacobheun commented 4 years ago

@requilence can you look into the failing tests?

@vyzo can you give a quick review of this

BigLep commented 3 years ago

@vyzo : will close and link to the appropriate issue.

BigLep commented 3 years ago

@vyzo : did you create the appropriate issue so we can close this?

vyzo commented 3 years ago

@BigLep We already have #402.