search

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
321 stars 185 forks source link

Add Topic() method to Topic struct. #370

Closed lthibault closed 4 years ago

lthibault commented 4 years ago

Fixes #358 and part of #198.

aschmahmann commented 4 years ago

@vyzo you good with merging this?

vyzo commented 4 years ago

We want a String() method I think, but I am not going to block it.

lthibault commented 4 years ago

@vyzo I initially used Topic because it is used by Subscription, but I actually agree that String is better.

Shall I make the change?

vyzo commented 4 years ago

yes please!

lthibault commented 4 years ago

@vyzo Done!