search

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
319 stars 185 forks source link

Reduce logging around redundant greylisting side-effects #380

Closed placer14 closed 4 years ago

placer14 commented 4 years ago

As a dev who analyses log output from apps which consume libp2p (lotus), I want greylist side-effects to not be so verbose. Both to minimize the amount of overhead needed to manage piping reduncing information to disk but also remove noise from logs for easier anaysis.

The issues are especially prevelent when the libp2p node is experiencing a DoS attack.

Example output we want to avoid: image

vyzo commented 4 years ago

What version of lotus are you running? This should be resolved in latest master, we fixed an issue around negative scores.

vyzo commented 4 years ago

We can certainly reduce the verbosity however.

vyzo commented 4 years ago

actually info is not all that verbose.

vyzo commented 4 years ago

also of note you can reduce subsystem verbosity directly; try

lotus log set-level --system pubsub warn
placer14 commented 4 years ago

Thanks for the suggestion This looks to be on v0.3.4. Is there a way to apply this via environment variable or as a flag to lotus daemon on startup? Would rather deploy this node config more "atomically" rather than in a two-step "init->config" process.

vyzo commented 4 years ago

I don't know whether it can be set in the config, but we can try to find out :) Also note that lotus master is now on v0.3.5 (and all the spacerace releases include the fixes from pre-v0.3.5 master).