search

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
319 stars 185 forks source link

feat: update to go-libp2p-core 0.7.0 #385

Closed Stebalien closed 3 years ago

Stebalien commented 4 years ago

Updates to the new stream interfaces. See https://github.com/libp2p/go-libp2p-core/releases/tag/v0.7.0.

protolambda commented 3 years ago

Interested in this PR, currently pubsub is broken with latest libp2p core version, due to the FullClose missing helper function. Can I help?

Stebalien commented 3 years ago

Please downgrade go-libp2p-core (i.e., use the version referenced by the latest go-libp2p). This patch set got stuck on some unexpected issues but should unstick within a few weeks.

protolambda commented 3 years ago

You mean this PR? The CI just says that there are some unused imports. The helpers package is not used anymore. Or is there something else to wait for?

Stebalien commented 3 years ago

This is waiting on https://github.com/libp2p/go-libp2p/pull/1001, which is blocked on some very tricky issues in protocol negotiation.

Stebalien commented 3 years ago

Also, should handleNewStream call Close instead of Reset now or is leaving it as Reset the intended behavior?

It doesn't really matter in that case. That'll only happen when we're shutting down (who cares) or we've already disconnected from the peer (again, who cares). We only call "close" in the case where the peer sends os a nice EOF for some reason (which will never happen in the go implementation, actually...).

vyzo commented 3 years ago

Yeah, looks fine -- @stebalien will prod when it's time to merge (go-libp2p and every thing else must be ready first).

Stebalien commented 3 years ago

@vyzo all done. Merge when ready.