Use protobof message type for signed envelope - Githubissues

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p

https://github.com/libp2p/specs/tree/master/pubsub

Other

319 stars 185 forks source link

Use protobof message type for signed envelope #391

Closed blacktemplar closed 3 years ago

blacktemplar commented 3 years ago

Is there any specific reason why the type of a signed address record in the protobuf specification https://github.com/libp2p/go-libp2p-pubsub/blob/89f61abf299aeb209e3293034da7a0b7b318f404/pb/rpc.proto#L56 is bytes and not the protobuf message type Envelope defined in the specs https://github.com/libp2p/specs/blob/rfc/address-records/RFC/0002-signed-envelopes.md#wire-format?