search

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
319 stars 185 forks source link

ci: add windows ci #404

Closed aschmahmann closed 3 years ago

aschmahmann commented 3 years ago

I've noticed some issues when running tests on Windows, we should really track this in CI.

@vyzo how do you feel about moving away from Travis? @marten-seemann has been working on some CI standardization using GitHub actions in https://github.com/ipld/.github/

vyzo commented 3 years ago

Sure, we are not married to travis.

marten-seemann commented 3 years ago

We can include this repo in the new GitHub Actions workflow, as soon as we get it deployed PL-wide.

vyzo commented 3 years ago

Sure let's do that.

@aschmahmann the windows ci is timing out; this is probably travis sucking, but maybe there is a real issue underneath.

aschmahmann commented 3 years ago

@vyzo I think this is a real thing, not just Travis. This sometimes happens on my laptop too.

There are also a couple test failures related to writing to /tmp instead of Go's OS agnostic temporary directory.

vyzo commented 3 years ago

care to fix those tests in the pr?

aschmahmann commented 3 years ago

Yep, I can definitely do the /tmp fixes here. The hanging might take me some time before I can look into it though

vyzo commented 3 years ago

we have dropped travis, as it is horribly broken; closing.