fix: avoid validating messages from ourself before sending

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p

https://github.com/libp2p/specs/tree/master/pubsub

Other

319 stars 185 forks source link

fix: avoid validating messages from ourself before sending #405

Closed Stebalien closed 3 years ago

Stebalien commented 3 years ago

The potential downside is that we could get blocked for sending invalid messages. But the upside is that outbound messages:

Don't incur a validation cost.
Can't get dropped because our validation queue is overloaded.

fixes #398

vyzo commented 3 years ago

Discussed this synchronously with @stebalien and we decided that the right solution to this problem is to have a separate validation path for own messages that validates synchronously and returns an error to the user.

Closing.