libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
319 stars 185 forks source link

Strengthen Validation Of Gossip Scoring Parameters #410

Closed nisdas closed 3 years ago

nisdas commented 3 years ago

During further testing of our parameters for peer scoring, we came across some unusual scores for a significant amount of our peers, with a large amount giving their score as NaN. On further investigation it came about that when initializing the scoring parameter there had been an arithmetic error when determining the parameter. This lead to the parameter being initialized with a negative infinite value. The parameter validation was unable to capture this, which is the main reason this PR has been opened up.

vyzo commented 3 years ago

@nisdas do you mind rebasing on master? I just merged #406 which disables the flaky test that keeps failing on travis.

vyzo commented 3 years ago

thank you!