search

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
319 stars 185 forks source link

add go-check workflow, fix gofmt, go vet and staticcheck #417

Closed marten-seemann closed 3 years ago

marten-seemann commented 3 years ago

Closes #415. Closes #416.

I see that running go test is more complicated on this repo, so we should probably not move it to GitHub Actions (yet). @coryschwartz did an excellent job fixing all the go vet and staticcheck errors. We should merge these changes, and add the go-check workflow.

marten-seemann commented 3 years ago

No idea why Circle is failing here. Seems to be unrelated to this PR. Some git clone failure?

vyzo commented 3 years ago

The CircleCI failure is odd, seems it can't checkout the code because of some key issue -- maybe credential rotation?

vyzo commented 3 years ago

We might need to refresh the deploy key in the project settings? I don't have admin to do that however, @marten-seemann do you have perms? Otherwise, @stebalien might be able to help.

jacobheun commented 3 years ago

We might need to refresh the deploy key in the project settings? I don't have admin to do that however, @marten-seemann do you have perms?

I missed a few readds when I cycled keys due to the codecov incident last week. Remaining repos should have the new keys now

vyzo commented 3 years ago

the changes with the error channels seem to have broken some tests...

mvdan commented 3 years ago

I think all the new channels should be unnecessary; just use Errorf where the original code used Fatalf :)

aschmahmann commented 3 years ago

@marten-seemann @vyzo what's the status of this PR?

marten-seemann commented 3 years ago

@aschmahmann Due to the resource requirements (especially fds) of the test suite here, we removed this repo from the automation: https://github.com/protocol/.github/pull/51. We can also close this PR.