question: msgId and possible memory leak?

richard-ramos commented 1 year ago

Hello! I'm trying to debug a memory leak I see in my project. After executing pprof --inuse_objects (to see objects allocated but not yet released), I end up with the following stats:

File: waku
Build ID: 9a40b11966dcdbae7d63435fc764c898ae39db63
Type: inuse_objects
Time: Mar 9, 2023 at 6:06pm (UTC)
Entering interactive mode (type "help" for commands, "o" for options)
(pprof) top 10
Showing nodes accounting for 2068186, 97.91% of 2112367 total
Dropped 175 nodes (cum <= 10561)
Showing top 10 nodes out of 64
      flat  flat%   sum%        cum   cum%
   1392682 65.93% 65.93%    1392682 65.93%  github.com/waku-org/go-waku/waku/v2/protocol/relay.msgIdFn
...

(pprof) list relay.msgIdFn
Total: 2112367
ROUTINE ======================== github.com/waku-org/go-waku/waku/v2/protocol/relay.msgIdFn in /root/go-waku/waku/v2/protocol/relay/waku_relay.go
   1392682    1392682 (flat, cum) 65.93% of Total
         .          .     54:func msgIdFn(pmsg *pubsub_pb.Message) string {
   1392682    1392682     55:   return string(utils.SHA256(pmsg.Data))
         .          .     56:}

So far I havent been able to successfully identify the reason for this custom messageID function to be present in the top10, but in the meantime I was looking at the code that calls the message Id function and saw this code: https://github.com/libp2p/go-libp2p-pubsub/blob/829f9026a3dcf12b268efad6a140dd99446cf17b/mcache.go#L97-L98

Since maps do not shrink when elements are deleted as described here https://github.com/golang/go/issues/20135, isn't it possible that a memory leak exists for mc.msgs and mc.peertx depending on the volume of messages that is received in a node?

nisdas commented 1 year ago

Just saw this issue, but its most likely fixed here https://github.com/libp2p/go-libp2p-pubsub/pull/528

There has been a new release with the change, so you could give that a shot and see if it fixes your issue.

vyzo commented 1 year ago

yes, that's probably it. Sorry guys!

richard-ramos commented 1 year ago

Thank you! this fixes the issue

libp2p / go-libp2p-pubsub

question: msgId and possible memory leak? #526