search

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
309 stars 178 forks source link

Message rebroadcast hours later #529

Open gvelez17 opened 1 year ago

gvelez17 commented 1 year ago

While investigating a Pubsub Flood: https://github.com/libp2p/go-libp2p-pubsub/issues/524 in which the same sequence number appears multiple times, we have seen cases where the same From and Seqno appear as much as 6 hours apart.

This exceeds most reasonable cache sizes. Is there a way to prevent this behavior?

image

vyzo commented 1 year ago

We recently introduced default validators with an implementation that rejects old sequence numbers.

It can be improved (planned follow up to use a sack bitfield for tracking the last 64 msgs), but it can solve your problem.