search

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
328 stars 186 forks source link

Next function returns own messages #537

Open l0k18 opened 1 year ago

l0k18 commented 1 year ago

Sorry if this is a duplicate. It is happening with v0.9.3, which appears to be the current latest version.

The title really says it all. I added this code to my handler to abort doing any work if the sender is the receiver:

    if p.ReceivedFrom == ng.Listener.Host.ID() {
        return
    }

Yes, Listener.Host is libp2p.Host.

It seems to me that the Next function should not deliver messages that the pubsub sent. At least it should be an option to suppress it.

vyzo commented 1 year ago

This is the default behavior of broadcast protocols; a pr would be welcome if you want to add an option to disable this behavior.

l0k18 commented 1 year ago

This is the default behavior of broadcast protocols; a pr would be welcome if you want to add an option to disable this behavior.

I will attach one to this issue in the near future, A parameter and that code more or less.