Closed Stebalien closed 1 month ago
Apparently pubsub uses the "blank" host in tests, which doesn't support identify.
Tests should be fixed by https://github.com/libp2p/go-libp2p-pubsub/pull/565.
This conflicts with https://github.com/libp2p/go-libp2p-pubsub/pull/440. I'd prefer to just remove that feature because it doesn't work reliably with identify.
I agree, but we should check with users of the feature. If there is none, no problem.
If it is in use, we might have to make some changes; maybe have a user function to test instead of directly comparing with the router protocols?
Hm. You're right, we have the function and can just use that.
Ok, it should all work correctly-ish now. Or, well, correct enough.
fixes #546