libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
328 stars 186 forks source link

Added missing Close call on the AddrBook member of GossipSubRouter #568

Closed sstanculeanu closed 4 months ago

sstanculeanu commented 4 months ago

While upgrading our dependency from v0.9.3 to v0.11.0, our goroutine monitoring tests reported a hanging goroutine from pubsub.

Digging a bit, we discovered that v0.11.0 added a new AddrBook member of GossipSubRouter, but Close method of this is never called.

I've created this PR with the fix. Probably the proper fix would be to also update the AddrBook interface from go-libp2p to export the Close method. This way the cast would be avoided.