search

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
327 stars 186 forks source link

Fix flaky tests TestGossipsubConnTagMessageDeliveries #574

Open ppopth opened 2 months ago

ppopth commented 2 months ago

This is a follow-up issue from https://github.com/libp2p/go-libp2p-pubsub/pull/553#issuecomment-2291002843

vyzo commented 2 months ago

@MarcoPolo can we get someone from the shipyard to look at this?

MarcoPolo commented 2 months ago

I'll do this today

vyzo commented 2 months ago

thank you!

MarcoPolo commented 2 months ago

I'm having a hard time finding where FuzzAppendOrMergeRPC fails. Can you point me to that failure? I see that TestGossipsubConnTagMessageDeliveries fails here: https://github.com/libp2p/go-libp2p-pubsub/actions/runs/10390911953/job/28772599092

vyzo commented 2 months ago

check the failure history in #553 -- maybe a bug was introduced there?

Feel free to review.

MarcoPolo commented 2 months ago

I've looked through all the test logs of that branch run in the last week and don't see a time where FuzzAppendOrMergeRPC fails. The comment here quotes this:

...
--- PASS: TestTopicPublishWithKeyInvalidParameters (0.08s)
--- PASS: TestTopicPublishWithKeyInvalidParameters/nil_sign_private_key_should_error (0.00s)
--- PASS: TestTopicPublishWithKeyInvalidParameters/empty_peer_ID_should_error (0.00s)
=== RUN   FuzzAppendOrMergeRPC
--- PASS: FuzzAppendOrMergeRPC (0.00s)
FAIL
FAIL    github.com/libp2p/go-libp2p-pubsub  385.852s
-test.shuffle 1723651417916320350

On a quick glance you may think FuzzAppendOrMergeRPC failed, but it didn't. It PASSed.

vyzo commented 2 months ago

ok, then it's not a suspect! Thanks for digging in.