libp2p / go-libp2p-routing-helpers

MIT License
11 stars 16 forks source link

fix: cancel parallel routers #71

Closed dennis-tra closed 1 year ago

dennis-tra commented 1 year ago

Fixes a bug where we wait for parallel routers to return a value although we already have one. Before this change, we would have waited for all routers to return a value.

cc @Jorropo

github-actions[bot] commented 1 year ago

Suggested version: v0.6.1

Comparing to: v0.6.0 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index 3dfb071..e6b7756 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,6 @@
 module github.com/libp2p/go-libp2p-routing-helpers

-go 1.18
+go 1.19

 require (
    github.com/hashicorp/errwrap v1.1.0

gorelease says:

# summary
Suggested version: v0.7.0

gocompat says:

Your branch is up to date with 'origin/master'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files. The Release Checker is not able to analyse files that are not checked in to master. This might cause the above analysis to be inaccurate. Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

Pre-creating GitHub Releases on release PRs initiated from forks is not supported. If you wish to prepare release notes yourself, you should create a draft GitHub Release for tag v0.6.1 manually. The draft GitHub Release is going to be published when this PR is merged. If you choose not to create a draft GitHub Release, a published GitHub Released is going to be created when this PR is merged.

BigLep commented 1 year ago

@Jorropo : a couple of things:

  1. For my own learning, is there a reason we went with 0.6.1 instead of 0.7.0 as suggested by gorelease?
  2. Is this going to be bubbled up to go-libipfs?
Jorropo commented 1 year ago

@BigLep gorelease suggest 0.7.0 because the go version in the go.mod was changed, I think it's kinda stuppid because our projects only support the two latest go release. So IMO this is a totally break free patch which fixes a bug so this should be a patch release.