search

libp2p / go-libp2p-webrtc-direct

A libp2p transport that enables browser-to-server, and server-to-server, direct communication over WebRTC without requiring signalling servers
MIT License
82 stars 18 forks source link

Migrate to go-libp2p-core #31

Closed backkem closed 5 years ago

backkem commented 5 years ago

go-libp2p-core now holds the main interfaces and abstractions that make up go-libp2p, see libp2p/go-libp2p#602. We should use it to reduce the dependency graph.

jukie commented 5 years ago

I'd love to help out, how would I properly test my changes? Could you possibly add some contribution docs?

backkem commented 5 years ago

Hi @Jukie, would love to have you. The package tests run a rather extensive test suite. So, just running go test should give you a good indication.

jukie commented 5 years ago

Awesome, thanks for the info!

raulk commented 5 years ago

I missed migrating this one! Could you send a PR to get this repo added to the libp2p/workspace-go-libp2p repo?

backkem commented 5 years ago

@raulk I tried to add the submodule to libp2p/workspace-go-libp2p but I don't have the rights to push to this repo.

raulk commented 5 years ago

@backkem sent you an invite

backkem commented 5 years ago

Fixed by #30